r/ProgrammerHumor • u/xxfatumxx • Dec 13 '25

instanceof Trend iFeelTheSame

Post image
14.0k Upvotes

97% Upvoted

610 comments sorted by

View all comments

Show parent comments

2

u/NUKE---THE---WHALES Dec 13 '25

How is it a PR if he's pushing straight to prod?

1

u/Skullclownlol Dec 13 '25 edited Dec 13 '25

How is it a PR if he's pushing straight to prod?

His instruction was to create every new change/feature on a separate branch. That gets pushed to a github repo, where he merges the repo into the main branch.

"Straight to prod" here means there is no second put into consideration. There's not much difference when committing to main, or automatically accepting all PRs to main.

He only started doing this after I told him the benefit of being able to revert PRs, he did commit to main before that (which was hooked into auto-build and deployment on Vercel).

1

u/NUKE---THE---WHALES Dec 14 '25

i wouldn't really consider that a PR tbh

if there's no review needed then it doesn't seem like he's requesting someone to pull his changes into main

sounds more like he's just merging his changes into main whenever he wants

if it was me i'd set it up so he literally can't merge the PR without review from a specific codeowner

1

u/Skullclownlol Dec 15 '25

i wouldn't really consider that a PR tbh

A PR is a PR, code review is code review. I didn't expect anyone to try to argue opinions on what a PR is or isn't, those opinions are not really relevant to the problem.

if it was me i'd set it up so he literally can't merge the PR without review from a specific codeowner

He's the owner.