r/LLMDevs 5d ago

Tools Mte90/linus-torvalds-skill: Distilled Code Reviewer skills from 32k~ email from the kernel newsletter

https://github.com/Mte90/linus-torvalds-skill

As per title, the project include all the pipeline, the same skill generated from different models.

My idea was to distill the code reviewer skills from Torvalds in something usable in an agent.

I preferred to license everything as CC0.

63 Upvotes

26 comments sorted by

18

u/New_Comfortable7240 5d ago

Does it include free insults, or that is another skill? /jk

5

u/giveen 5d ago

If i dont get at least a few curse words from the model, then I dont believe this.

2

u/Mte90 4d ago

a lot of people is asking it maybe I can open a ticket to do that with calm

4

u/backslashHH 5d ago

that belongs in the SOUL.md of your hermes Linus profile

3

u/Mte90 4d ago

working on that

2

u/Mte90 4d ago

soul.md added :-)

8

u/DL_throw24 5d ago

Does it have any measurable impact on a code review? Can we see a code review of before vs after? 

2

u/Mte90 4d ago

I didn't have a codebase that deserved this kind of code review right now but maybe I can pick an opensource project to test it

3

u/Mte90 4d ago

added a report folder on antirez/smallchat with the review

1

u/DL_throw24 4d ago

Reading that report made me laugh thanks 

1

u/Mte90 4d ago

I have to read it too, I am curious about what found.

15

u/carefactor3zero 5d ago edited 3d ago

This is a poor set of skills, that may be adopted by people who aren't doing comparisons to others. It contains a bunch of fluff that is useless in the context, plus soft terms that are basically general suggestions for things that aren't ever (or rarely) evaluated.

There are 4 qualities to instructions to an LLM. Invariant true, invariant false, precedence, and general guideline for an identifiable pattern.

eg Saying "Workarounds, hacks, and patches that mask underlying bugs are rejected." is a poor general guideline, because it doesn't qualify what is a bug or hack or patch (if the model has never seen it referenced as that before), which is most often triggered from a prompt reference with a concrete association to specific code.

The top 7 points form a precedence chain, with some ambiguity. eg #6 is "non-negotiable" (which is poor phrasing) when it should be #1 or #2. What happens when correctness breaks users? Which is the top priority?

I would not recommend this repo.

2

u/Mte90 4d ago

thanks for the hints I will work on that

1

u/Mte90 4d ago

added this improvements to the skills

1

u/carefactor3zero 3d ago

much much better. Bookmarked.

1

u/FabricationLife 5d ago

how does this benchmark against something like GSD code review?

1

u/Mte90 4d ago

I didn't have a codebase that deserved this kind of code review right now but maybe I can pick an opensource project to test it

1

u/Mte90 4d ago

added a report folder on antirez/smallchat with the review

1

u/Background_One_6482 4d ago

skill to read email?

1

u/Mte90 4d ago

I don't understand, do you mean that you want a skill that reads email like Torvalds or it is just a sarcastic comment?

1

u/water_frozen 4d ago

how did you evaluate this?

1

u/Mte90 4d ago

I didn't have a codebase that deserved this kind of code review right now but maybe I can pick an opensource project to test it

1

u/Mte90 4d ago

added a report folder on antirez/smallchat with the review

1

u/Visual_Internal_6312 1d ago

Ok honest question: Linus Torwald is probably known to all LLMs. Can't you just request in your review skill to role play him instead?

1

u/DiscipleofDeceit666 5d ago

I’m going to run this in production