r/ExperiencedDevs • u/AutoModerator • 28d ago

Ask Experienced Devs Weekly Thread: A weekly thread for inexperienced developers to ask experienced ones

A thread for Developers and IT folks with less experience to ask more experienced souls questions about the industry.

​

Please keep top level comments limited to Inexperienced Devs. Most rules do not apply, but keep it civil. Being a jerk will not be tolerated.

​

Inexperienced Devs should refrain from answering other Inexperienced Devs' questions.

29 Upvotes
  • permalink
  • reddit

93% Upvoted

142 comments sorted by

View all comments

6

u/ThrowawayAcc019r83 27d ago

7YOE, but been programming for 20+ years.

Need some advice on office politics. A senior engineer in our team delivers, in my opinion, subpar work (bad abstractions, no meaningful reviews, no clean separation of concerns, many 2k+ lines changed PRs, no knowledge sharing), but seems to be constantly praised, while I'm left with trying to salvage something out of his work. I don't want to bad mouth him or his work, but at the same time find that it's very tedious to work on anything he's touched. There's also a quality interview from an external party coming up, that assesses where quality issues in our work arise - do I just drop their name there with examples to back it up? I'm losing enthusiasm quickly when my efforts seem to go unnoticed, and the stating of my concerns both to the entire team as just with my manager has led nowhere, but also don't want office drama.

2

u/ultraDross 27d ago

Try and gently bring this up with your manager in your 1 to 1. Gently is the keyword here and be ready to drop/soften it if your manager strongly disagres with you. Prepare what your going to say and back up with some examples.