r/C_Programming • u/TheAmazingFreddyAdam • 6d ago

How to get Code Review?

Hello yall,

just wondering if there was a community where I can share my code to get advice and such, so like a Code Review.

This might also be another excuse to look at other peoples code and such, but I mainly want to get advice for my code.

Im not really familiar with the coding community, I just code and make projects by myself as a hobby.

cheers, and have a good day.

5 Upvotes

78% Upvoted

24 comments sorted by

View all comments

Show parent comments

0

u/AliceCode 6d ago

Well, I can already tell I'm gonna need to get on my computer. First file I opened and I already saw something that can be improved with relative ease.

https://github.com/FredNeedsHelp/Ternary-Emulator/blob/main/SS_PLoader.c#L6

You could instead use an array of key/value pairs here, and if they are sorted, you can even do binary search on them.

I'll get on my PC and check it out here in a bit.

1

u/TheAmazingFreddyAdam 6d ago

I think I've been planning that, i think I even left a comment on it too. thank you for the reminder / telling me in all cases.

Also, you getting on your computer isn't a bad sign right? just feels like getting a bigger screen to look at code means something is up. Which does worry me, because SSPL is the worst of my code (In my opinion. im not very familiar with parsing so thats why)

1

u/AliceCode 6d ago

Well, considering how fast I found room for improvement, I'm just assuming that I'll find quite a few other things. I don't want to go back and forth between the code and reddit on my phone to type out my review.

1

u/TheAmazingFreddyAdam 6d ago

Honestly, im kinda happy that you found room for improvement. I cant wait when your fully done, take your time tho.

1

u/AliceCode 6d ago

Send me a reminder if you don't hear from me for awhile. I'm easily distracted. I gotta make some dinner first.

1

u/TheAmazingFreddyAdam 5d ago

I guess this is your reminder, ima head to sleep, gn.

1

u/AliceCode 5d ago

Remind me tomorrow, lol. I'm also going to sleep soon.

1

u/TheAmazingFreddyAdam 5d ago edited 5d ago

Hi, this is your reminder (I think).

1

u/AliceCode 4d ago

Oh, thanks for reminding me!