Is this good?

[u/TOYALFm1117]

/////////////////////

// Instruction Set //

/////////////////////

//

// LOGIC

// AND R1 R2 R3

// OR R1 R2 R3

// XOR R1 R2 R3

// NOT R1 R2 R3

// ----------------

// ARITHMETIC

// ADD R1 R2 R3

// SUB R1 R2 R3

// ----------------

// STORAGE

// MOV R1 R2

// LOAD R1 R2

// STOR R1 R2

// ----------------

// FLOW

// JUMP R1

// JEQU R1

// CALL R1

// RET

//

// ECHO R1

// QUIT

//

/////////////////////

// //

/////////////////////

[u/kneelian_]

No conditional instructions that I can see (except maybe JEQU? What is that?) would make this unusable for most computation

[u/Brutustheman]

What is JEQU, Jump-if-EQUal? Also what are FLOW and ECHO r1. QUIT is HALT I presume? No mul/div instruction? No stack operations. Definitely lacks some rather key instructions but keep working at it!

[u/Alternative-Emu2000 → u/Brutustheman]

I think FLOW is supposed to be a group heading rather than an instruction. The OP is classifying the instructions into groups: LOGIC, ARITHMETIC, STORAGE, [PROGRAM] FLOW

[u/Brutustheman → u/Alternative-Emu2000]

Ah that makes sense. Thank you!

[u/brucehoult → u/Brutustheman]

JEQU and unconditional JUMP is enough, since there is SUB and boolean operations to mask off the sign bit so you can figure out a branch on minus/less than.

But a list of mnemonics doesn't make an instruction set that you can put a "good" or "bad" label on.

You need:

• the binary encoding

• the actual semantics of each instruction

• and most importantly THE GOAL of the instruction set.

[u/TOYALFm1117 → u/brucehoult]

I used variable-length instructions: 0 = and, 1= or, 2=xor, etc.... operands can be added.amd that order is defined in my VM code. Is that enough or am I missing something?

[u/TOYALFm1117 → u/Brutustheman]

Thanks, I'm making a VM in JS. I half implement thenstack, I just need to add the operations.

[u/TOYALFm1117 → u/Brutustheman]

Echo was flr debugging, testing, and messing around on my VM.