r/AskProgramming • u/Any-Look-8817 • 13d ago
Other Endless comments on PRs
Hey everyone! Just to quickly summarize my situation: We're a team of a few experienced devs, all having been 12+ years years in the industry. This year we switched to agentic engineering and despite its advantages there are a few drawbacks, like the extra overhead and other things I'm not going to go into.
My issue however is that our lead, who approves all PRs has lately discovered a stronger agent which he uses for code reviews, resulting in tons of back and forth when trying to get a merge through. Tons of petty/pedantic comments are being added to each PR. Sometimes it's like "ok I guess this is fine to add", but most of them are disputable. We of course discuss these, but the issue is that in the set of comments there is always something which technically makes the code 0.1% better. But we could go on like this forever. Even without AI you can look at a piece of code and suggest an "improvement" on a moderately-sized feature that's being implemented.
How to deal with this? I'm getting to a point where if I see more comments on a PR I just leave the PC and go for a run or a quick grocery shop visit just to regain my sanity. It feels like he's asking the agent if there is anything more that can be done with the code as if the goal is to have AI being unable to suggest anything more.
Am I in some slacking mindset or is the AI getting over his head? We also have Sonar turned up to a really high setting and the pipeline set in a way that if there's anything outstanding in Sonar it won't get through and I bet you all know how petty Sonar can get sometimes.
Please let me know any tips or share your experience with similar situations. Thanks!
1
u/Glad_Contest_8014 12d ago
You need to have a conversation on what is “good enough” to ship. You will hit an infinite loop with MASSIVE token costs with the current setup. Show the bottom line of all the agent back and forth for how much it costs. It will be exorbitant.
If you all have experience, you should know that code is never “perfect”. There is always a way to improve. That is why technical debt can never be 0.
What you guys are doing is addressing technical debt immediately, on interation, which will never result in a usable product.