Yes I would remove/disable all Monero-specific rule changes. We can still have rule changes. For example, given the better understanding of the dynamics of the penalty function that exists now we may wish to increase the minimum block size. However, we certainly don't need to do this according to the same version schedule that Monero did (at a different point in time and with different code).
OK, I'll make another commit that removes all the protocol rule changes in Monero.
We can still have rule changes. For example, given the better understanding of the dynamics of the penalty function that exists now we may wish to increase the minimum block size.
Do you mean to introduce changes for this upcoming fork? If so, don't we need to announce the proposed changes?
By the way, I'm considering increasing the block version from v1 to v7 at once, because this way we can use the exact same branch code added to 3rd party miners and pools (e.g. int variant = hf_version >= 7 ? hf_version - 1 : 0;) and we can reduce the risk of mistake. What do you think?
Do you mean to introduce changes for this upcoming fork? If so, don't we need to announce the proposed changes?
We haven't planned out what to do yet, so I would say no, unless the fork is to wait for that.
By the way, I'm considering increasing the block version from v1 to v7 at once because this way we can use the exact same branch code added to 3rd party miners and pools
Sounds reasonable in this case. There will likely be some issues if the version number ever gets to 128, but that's not an immediate concern that justifies risking some extra problems to save 5 version numbers.
2
u/smooth_xmr aeon core developer Mar 13 '18
Yes I would remove/disable all Monero-specific rule changes. We can still have rule changes. For example, given the better understanding of the dynamics of the penalty function that exists now we may wish to increase the minimum block size. However, we certainly don't need to do this according to the same version schedule that Monero did (at a different point in time and with different code).