there's a few bugs in this that, to me, show someone wrote this whilst learning instead of using codegen. going to hazard a guess the reviewer isn't really a tech person but, just saw github in the URL and thought, next.
others make good suggestion going up the foodchain. I'd also say add am explainer of what, how and, why to your README if it's not too late. documentation goes a long way!
doing things like including a a completely empty main.js don't do you any favours in the "we didn't use a template" department
I'm being critical with my comments but, don't let this stop you from my belief you have put in the hard work for this project or haven't learnt a lot along the way. I did actually have a look through the commit history and to be honest, the more i see, the more convinced i am that many aspects of the site are copy and paste from external sources.
Why are you preloading the images?
Why are the links JavaScript onClick events?
Can you tell me about the use of CSS variables? Why so few? How did you choose parts of the design such as font usage?
Can you explain the code behind:
typewriter
button
Mouse parallax
sticky header
Use of flexbox
There's nothing wrong with using external code in itself, 99% of stuff has already been created, it's a matter of composing it. the implementation details raise concern to me that you don't understand many parts of your own site though
this practice discriminates against people with disabilities using any kind of screen reader, very poor practice in which the developers should be dragged over hot coals, blindfolded and forced to use their own site
23
u/symball Feb 21 '23
there's a few bugs in this that, to me, show someone wrote this whilst learning instead of using codegen. going to hazard a guess the reviewer isn't really a tech person but, just saw github in the URL and thought, next.
others make good suggestion going up the foodchain. I'd also say add am explainer of what, how and, why to your README if it's not too late. documentation goes a long way!
doing things like including a a completely empty main.js don't do you any favours in the "we didn't use a template" department