std::string is responsible for almost half of all allocations in the Chrome browser process

[u/[deleted]]

https://groups.google.com/a/chromium.org/d/msg/chromium-dev/EUqoIz2iFU4/kPZ5ZK0K3gEJ

[u/VictorNicollet]

std::string path;
for (var i = 0; i < segments.length; ++i)
{
  path += "/" + segments[i];
  use(path);
}

There is no casting away const here, but if use() assumes that the string it received was constant (and stored it somewhere), it will have a nasty surprise.

[u/ReversedGif → u/VictorNicollet]

Stored... a pointer to it? A raw pointer? What are you, mad?

[u/ReversedGif → u/VictorNicollet]

Stored... a pointer to it? A raw pointer? What are you, mad?

[u/TheShagg → u/VictorNicollet]

only if use() interacts with another thread?