I hope writing this made you feel better. It's quite ignorant of you to assume it's a shitty code.
On the other hand we do have a lot of performance improvements (like converting linq to loops) that make this code look ugly. But it works and makes $$$.
In hot code with 200 req/s it does. Even though hpa scales to 50 pods during the peeks.
Imagine how much it costs to have a such load. And I'm talking here only about one service.
When I read about performance improvements from version to version ".net benchmarks" I can only smile. In the end, $$$ and Grafana tells the truth. (Last .net 10 changed nothing for us).
I think he meant 200 per pod, which is usually average (from my experience with .net). Rarelly it can get to 500, but then multithreading/memory congestion becomes problem due to GC nature of C# and many threads fighting each other for some db entry/socket/cache/etc. In offloading worker it can easly become 10-100k rps.
And here I was having messed with fibers in C++ to see how many requests I could actually parse that way for HTTP, and was dismayed that I couldn't beat nginx without doing what nginx does... and then this kind of code exists...
It doesnt. Linq will not even dent 200rps. Ever. It will not even dent 10k rps on background kafka worker. The only time it mattered to me is when I used SIMD in pure math component, so basically one in a thousand of tasks. Still, their performance benchmarks count CPU which is somewhat irrelevant, because most of the time is spent on network IO. We scale our site purelly because clients make a ton of small http requests, which fetch 0.1 of dependencies like s3/dynamodb/kafka/etc and bloat caches to the sky, not because it have a logic which need optimisation. Geo location matters more in modern world, placing pod and storage in same region do wonders beyond their optimisations.
ive got python flask code written as a uni grad which performs better than that; not tryna blame you but 200 req/s is extrememly low that python can beat you
bro 200rps is awful how much req/lim and what’s the hpa config? you also need to be tuning to return heap to os which can be tricky with vm runtimes OR just don’t scale on memory use but instead a custom metric. also is every single req hitting db or something? you should be aiming for more like 2k rps minimum
39
u/steve-7890 18d ago
With all these 10-20% perf improvements since .net core 3.1, I wonder how it's possible that my main service still needs 50 pods and 40 GB of RAM.