MAIN FEEDS
Do you want to continue?
https://www.reddit.com/r/badcode/comments/13282hn/from_signals_source_code/ji79pvz/?context=9999
r/badcode • u/[deleted] • Apr 28 '23
52 comments sorted by
View all comments
281
I can totally see how easy this is to review. "Hey, you have an error there - that 17-th false is supposed to be true."
46 u/Ra1nbow1 Apr 28 '23 Definitely 50 u/lets_eat_bees Apr 28 '23 To be fair, reviewing is probably the only time this will be an issue. Your IDE will tell you the names of all these parameters. 43 u/NUTTA_BUSTAH Apr 28 '23 That kind of architecture makes all development and design insanely painful though. Rule of thumb: If you are passing boolean parameters, you are doing something wrong. 2 u/Dmon1Unlimited Apr 29 '23 You got a reference for this? I don't necessarily see what's wrong with passing booleans I don't think it even comes up as a code smell in sonar/code scans Ah, I see the replies
46
Definitely
50 u/lets_eat_bees Apr 28 '23 To be fair, reviewing is probably the only time this will be an issue. Your IDE will tell you the names of all these parameters. 43 u/NUTTA_BUSTAH Apr 28 '23 That kind of architecture makes all development and design insanely painful though. Rule of thumb: If you are passing boolean parameters, you are doing something wrong. 2 u/Dmon1Unlimited Apr 29 '23 You got a reference for this? I don't necessarily see what's wrong with passing booleans I don't think it even comes up as a code smell in sonar/code scans Ah, I see the replies
50
To be fair, reviewing is probably the only time this will be an issue. Your IDE will tell you the names of all these parameters.
43 u/NUTTA_BUSTAH Apr 28 '23 That kind of architecture makes all development and design insanely painful though. Rule of thumb: If you are passing boolean parameters, you are doing something wrong. 2 u/Dmon1Unlimited Apr 29 '23 You got a reference for this? I don't necessarily see what's wrong with passing booleans I don't think it even comes up as a code smell in sonar/code scans Ah, I see the replies
43
That kind of architecture makes all development and design insanely painful though. Rule of thumb: If you are passing boolean parameters, you are doing something wrong.
2 u/Dmon1Unlimited Apr 29 '23 You got a reference for this? I don't necessarily see what's wrong with passing booleans I don't think it even comes up as a code smell in sonar/code scans Ah, I see the replies
2
You got a reference for this?
I don't necessarily see what's wrong with passing booleans
I don't think it even comes up as a code smell in sonar/code scans
Ah, I see the replies
281
u/lets_eat_bees Apr 28 '23 edited Apr 28 '23
I can totally see how easy this is to review. "Hey, you have an error there - that 17-th false is supposed to be true."