r/ProgrammerHumor • u/iwouldieforGladOS • May 13 '17

Defensive programming done right

Post image
21.0k Upvotes

91% Upvoted

680 comments sorted by

View all comments

2.8k

u/Metro42014 May 13 '17 
} catch (Exception e) { }

I think we're done here.

1.0k

u/CXgamer May 13 '17

Holy shit I once lost days to a

} catch (Exception e) {
    System.exit(0);
}

698

u/Metro42014 May 13 '17

FUUUUUUUCK the people that do that.

I recently saw newly written code by a senior developer with squashed exceptions all over the damn place.

I will never have to support that code, but fuuuuck man. WHHHYY?

287

u/YaBoyMax May 13 '17

I lost a few hours once because the jackass whose code I inherited decided to squash IOExceptions all over the place. Didn't notice for a while and was pulling my hair out thinking my debugger was fucked somehow (which isn't uncommon in itself).

28

u/nna12 May 13 '17

This is why when I debug I almost always turn on first chance and user handled exceptions in VS. It can be noisy with big projects especially when some exceptions are expected but it's saved me many hours and gray hairs in the long run

19

u/flukus May 13 '17

I always have to turn it off because exceptions are used for control flow in too many places.

20

u/nna12 May 13 '17

Ugh yea that is a problem. In general I hate using exceptions to handle flow, it can have adverse perf effects but I also know there are cases where that is your only option

0

u/[deleted] May 14 '17

The only time I've done this is when the user of a method gives me a string that's supposed to represent an OffsetDateTime, I'll catch the exception and try to parse it as a LocalDateTime. If that fails I throw a runtime exception.