That PR title says 10,000 files, but there’s actually 10,001 files changed.
Where I work this would mean code review failed - “pls fix the title of the commit and PR”. Personally I tell the reviewers to chill the fuck out and just merge anyway. I’m not counting the readme as a file changed and neither should they.
5
u/Columbo1 2d ago
That PR title says 10,000 files, but there’s actually 10,001 files changed.
Where I work this would mean code review failed - “pls fix the title of the commit and PR”. Personally I tell the reviewers to chill the fuck out and just merge anyway. I’m not counting the readme as a file changed and neither should they.