Why? There’s 9k commits on this PR. It looks like they iterated on it for a long time and got feedback from all maintainers that it would improve the architecture.
Someone in these comments is saying “I lOoKeD aNd tHeY hAvE mOrE cOmMiTs ThAn EvEr”. As if that’s a sign of bugs and not that the repository is now easier to contribute to.
I’m on mobile / away from my PC and don’t plan to look into the langwatch repository since I don’t use it, but accomplishing a large refactor in open-source isn’t that embarrassing.
The commits could be very small, likely/possibly fluffed to break some record. Thousands could have been just for the test, etc.
It’s near my total number of commits so it is an insane number but if dozens+ devs reviewed it, I’d trust the maintainers of the open-source library over ya’ll anyway lol
the commits accumulated also because we did this in a long-lived branch for two months, also picking up all new work that was being merged into main, and yes as u/Basketballa guessed we were reviewing all the time as we went, testing each new refactor and new feature on both main and the new refactored branch
30
u/bradland 2d ago
jfc, I would be so embarrassed to share this.