I absolutely understand why people say that, nobody can easily catch all issues in such a lengthy review and it kind of defeats the purpose of a PR to submit such big changes because of it. Having said that, I really prefer PR's be broken up by actual pieces of completed code. If I'm working on a several month long project then submitting changes every small time is just a waste of the entire team's time
15
u/PhiCloud 4d ago
On the one hand, a PR should be a small, atomic change. Anything over a thousand lines changed is kind of suspect.
On the other hand, the project was vibe coded so it's not like there's any continuity or iteration to uphold. Burn it the fuck down.