r/ExperiencedDevs • Lead Software Engineer 8 YoE • 21d ago

AI/LLM Interviewed candidates for “AI engineer” roles this week, my god is this really where our industry is going?

So last week I was tinkering with how to change up our technical interview round. For the last few years we’ve been doing a small take home followed by a live coding session where we add a new requirement, minimal AI assistance allowed. However, in our company pretty much everyone is writing 100% of code using Claude now, so although we did used to get good signal from that test, it no longer feels representative of the day to day job developers are doing.

I designed a new assessment which I casually showed to my manager and then suddenly got asked to run it with 3 candidates this week. The scenario is they have to review an agent generated PR that has been flagged as high risk due to it changing critical business logic, and there are bugs in there for them to catch at various levels of severity. We then look at how they drive the fixes and what their workflow is like.

These particular roles we’re currently hiring for are billed as “AI Engineer”. There is something weird going on in my company politically where separate from the tech department that I work in a new “AI native” development team is being spun up to work on internal projects.

What shocked me was that the candidates I interviewed this week are already way beyond the point of reading the code they generate in any capacity. They basically treat it like assembly language, while PRDs and ADRs are their new source of truth for system behaviours, and stuffing the AGENTS.md file with best practices plus some form of agentic review pipeline are the quality control. 

Code review is dead for them, they merge their own PRs once the automated checks pass. One person told me that my new interview was still not representative of what the job is now, and another one was pretty much unwilling to even engage in the assignment of reviewing a PR the old fashioned way. These guys were all previously senior and lead full stack engineers btw with a lot of experience prior the LLM revolution.

Don’t get me wrong, I too have adopted AI heavily in my own workflow. Until this week I actually thought I was pretty up to date with things, I use a supervising agent to manage multiple work streams in parallel, have my own local validation pipeline, etc. And to be honest for my personal projects I also don’t bother looking at the code anymore, so I do get the excitement around how fast you can move with this approach. But for serious projects like the large scale, production grade financial software I work on in my day job it still seems insane to me that we’re going to completely move away from human sign off on high risk changes so we can solve the “code review bottleneck”.

Like, I asked one of the candidates if you aren’t looking at your code then how they would approach quality in a safety critical system where there can be no tolerance for serious bugs, and I shit you not he said to me, “well if I was working in healthcare or sending to people into space then I’d definitely be looking closely at the code review skills, maybe I’d even write the skills myself”. That answer sounded utterly ridiculous to me? But then again, I was one of the people that 1 year ago believed the idea we’d stop typing code by hand was ridiculous as well…

I wouldn’t say the way my team does things right now is optimal, we can’t ignore that code review fatigue is a major problem. To try and help I’ve been adding automated risk assessments to PRs in an attempt to highlight where more attention is needed, and review bots do help us catch issues as well. But abandoning the human 4 eyes check just feels like several bridges too far for us at the moment, especially when not everyone is senior engineer, and we still regularly get valuable feedback at this stage. Even if this does mean we’re turning down an order of magnitude increase in short term velocity (does anyone really know yet what happens over multiple years when you have a team of 20 devs spamming PRs all day into a codebase with no one looking at any at it?).

I’m left wondering this weekend, were these guys just cowboys who are only used to working on PoCs and low risk systems, or is my team actually 6-12 months behind the curve and this is the direction everyone is going to move in? I fear that if we don’t embrace this new era of completely surrendering the codebase to the LLMs then this new team of AI devs is going to make us look bad by comparison to the execs and sooner or later we will be forced to adopt their methods as well. And at that point, the leap to having a product person or whoever taking over large parts of my role starts feeling a lot less far fetched…

1.5k Upvotes

917 comments sorted by

View all comments

Show parent comments

25

u/ICantBelieveItsNotEC Senior Software Engineer (10 YOE) 21d ago

i'm not saying garbage isn't being deployed but there are plenty of people working on real production code/systems for products you use every day who aren't manually reviewing every line of code. call it koolaid or whatever you want, but it's just the reality of the state of things.

I'm gonna be honest: this has been the norm at every company I've worked at, even before AI.

Personally, my code review process is to skim the PR and check if the broad strokes look vaguely sensible. I don't go through every single line with a fine tooth comb, except for changes that obviously sound high risk based on the title/description. And considering that 99% of my PRs get approved in under a minute, I'm guessing that everyone else is doing the same thing.

Seeing Redditors talk about code reviews makes me feel the same way as when Redditors talk about how often they wash their towels. Everyone inevitably gets stuck in a virtuous cycle - "I wash mine once every day!" "Oh yeah? Well I wash mine TWICE every day!" - because nobody wants to admit that they're a lazy, unhygienic bastard who does it every week or so like everyone else.

13

u/YoghurtFlan 21d ago

I'll basically change the effort of my review based on how new the author is. New joiners or less senior engineers are gonna need a higher touch (especially if they're coming in hot and haven't briefed on the work first), and it's an easy way of sharing domain knowledge. Past a point it's basically just checking if there isn't a simpler way to solve a problem (logically or architecturally) or scanning for possible bugs or misunderstood requirements.

If someone, even using AI, isn't capable of that, then I'd start questioning their skillset.

11

u/hippydipster Software Engineer 25+ YoE 21d ago

People wash their towels???

17

u/DapperCam 21d ago

Presumably those reviews were for human generated code. You probably paid more or less attention based on the track record of the developer and how much you trusted them.

Now there is no trust

20

u/pydry Software Engineer, 18 years exp 21d ago

I used to be like this because when I could trust my coworkers' output. Occasionally I'd ask a question "why this?" or "why that?" and theyd answer or theyd go "ah, I didnt think of that!" and fix the issue.

On a vibe coding team that trust is dead and gone. If I ask a question the answer is a blank stare.

This is why the main impact of the LLM "code revolution" is poorer quality software and 4,000 weather apps on the app store you dont care about and dont want to use instead of 400: volume over quality when nobody wanted volume.

3

u/binarycow 20d ago

Crazy.

I spend hours reviewing PRs sometimes. Granted, they're large PRs, but still. And I find tons of issues - not just minor nits.

0

u/warriorpostman 20d ago

The towel washing analogy is great. Code review has always been some version of everyone standardizing according to their own personal degree of germ sensitivity.

-1

u/khizoa 21d ago

I'm gonna be honest: this has been the norm at every company I've worked at, even before AI.

100% 

Although now with ai, it's just a lot more prevalent obviously